media: saa7134: avoid a shift overflow
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 2 Sep 2020 06:37:12 +0000 (08:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 08:05:43 +0000 (09:05 +0100)
[ Upstream commit 15a36aae1ec1c1f17149b6113b92631791830740 ]

As reported by smatch:
drivers/media/pci/saa7134//saa7134-tvaudio.c:686 saa_dsp_writel() warn: should 'reg << 2' be a 64 bit type?

On a 64-bits Kernel, the shift might be bigger than 32 bits.

In real, this should never happen, but let's shut up the warning.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/pci/saa7134/saa7134-tvaudio.c

index 38f94b7..0b5d6f4 100644 (file)
@@ -697,7 +697,8 @@ int saa_dsp_writel(struct saa7134_dev *dev, int reg, u32 value)
 {
        int err;
 
-       audio_dbg(2, "dsp write reg 0x%x = 0x%06x\n", reg << 2, value);
+       audio_dbg(2, "dsp write reg 0x%x = 0x%06x\n",
+                 (reg << 2) & 0xffffffff, value);
        err = saa_dsp_wait_bit(dev,SAA7135_DSP_RWSTATE_WRR);
        if (err < 0)
                return err;