media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm

There are only two lines in mtk_vcodec_release_enc_pm, using
pm_runtime_disable and put_device instead directly.

Move pm_runtime_enable outside mtk_vcodec_release_enc_pm to symmetry with
pm_runtime_disable, after that, rename mtk_vcodec_init_enc_pm to *_clk
since it only has clock operations now.

Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
index 347f0d87e2ff5ee1fc437aff817ded469b0fe281..507ad1ea21048d7dfe19812fed8046ba5c8d16ab 100644 (file)
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
@@ -11,6 +11,7 @@
 #include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/of.h>
+#include <linux/pm_runtime.h>
 #include <media/v4l2-event.h>
 #include <media/v4l2-mem2mem.h>
 #include <media/videobuf2-dma-contig.h>
@@ -257,7 +258,7 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
                return PTR_ERR(dev->fw_handler);
 
        dev->venc_pdata = of_device_get_match_data(&pdev->dev);
-       ret = mtk_vcodec_init_enc_pm(dev);
+       ret = mtk_vcodec_init_enc_clk(dev);
        if (ret < 0) {
                dev_err(&pdev->dev, "Failed to get mtk vcodec clock source!");
                goto err_enc_pm;
@@ -369,7 +370,8 @@ err_enc_mem_init:
 err_enc_alloc:
        v4l2_device_unregister(&dev->v4l2_dev);
 err_res:
-       mtk_vcodec_release_enc_pm(dev);
+       pm_runtime_disable(dev->pm.dev);
+       put_device(dev->pm.larbvenc);
 err_enc_pm:
        mtk_vcodec_fw_release(dev->fw_handler);
        return ret;
@@ -458,7 +460,8 @@ static int mtk_vcodec_enc_remove(struct platform_device *pdev)
                video_unregister_device(dev->vfd_enc);
 
        v4l2_device_unregister(&dev->v4l2_dev);
-       mtk_vcodec_release_enc_pm(dev);
+       pm_runtime_disable(dev->pm.dev);
+       put_device(dev->pm.larbvenc);
        mtk_vcodec_fw_release(dev->fw_handler);
        return 0;
 }

diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c
index 0c8c8f86788c1e649bd6ea4d59392e33edaf0de4..0825c6ec4eb7990121b9e42948862038a28fa25b 100644 (file)
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c
@@ -13,7 +13,7 @@
 #include "mtk_vcodec_enc_pm.h"
 #include "mtk_vcodec_util.h"
 
-int mtk_vcodec_init_enc_pm(struct mtk_vcodec_dev *mtkdev)
+int mtk_vcodec_init_enc_clk(struct mtk_vcodec_dev *mtkdev)
 {
        struct device_node *node;
        struct platform_device *pdev;
@@ -86,13 +86,6 @@ put_larbvenc:
        return ret;
 }
 
-void mtk_vcodec_release_enc_pm(struct mtk_vcodec_dev *mtkdev)
-{
-       pm_runtime_disable(mtkdev->pm.dev);
-       put_device(mtkdev->pm.larbvenc);
-}
-
-
 void mtk_vcodec_enc_clock_on(struct mtk_vcodec_pm *pm)
 {
        struct mtk_vcodec_clk *enc_clk = &pm->venc_clk;

diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.h
index b7ecdfd74823bd978bd336f21f3dc9247a856b9c..bc455cefc0cd1a7a3182a6b66a512ef9490f384f 100644 (file)
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.h
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.h
@@ -9,8 +9,7 @@
 
 #include "mtk_vcodec_drv.h"
 
-int mtk_vcodec_init_enc_pm(struct mtk_vcodec_dev *dev);
-void mtk_vcodec_release_enc_pm(struct mtk_vcodec_dev *dev);
+int mtk_vcodec_init_enc_clk(struct mtk_vcodec_dev *dev);
 
 void mtk_vcodec_enc_clock_on(struct mtk_vcodec_pm *pm);
 void mtk_vcodec_enc_clock_off(struct mtk_vcodec_pm *pm);