r8152: Cancel hw_phy_work if we have an error in probe
authorDouglas Anderson <dianders@chromium.org>
Fri, 20 Oct 2023 21:06:54 +0000 (14:06 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 22 Oct 2023 10:46:17 +0000 (11:46 +0100)
The error handling in rtl8152_probe() is missing a call to cancel the
hw_phy_work. Add it in to match what's in the cleanup code in
rtl8152_disconnect().

Fixes: a028a9e003f2 ("r8152: move the settings of PHY to a work queue")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/r8152.c

index 201c688..d10b088 100644 (file)
@@ -9783,6 +9783,7 @@ static int rtl8152_probe(struct usb_interface *intf,
 
 out1:
        tasklet_kill(&tp->tx_tl);
+       cancel_delayed_work_sync(&tp->hw_phy_work);
        if (tp->rtl_ops.unload)
                tp->rtl_ops.unload(tp);
        usb_set_intfdata(intf, NULL);