f2fs: avoid victim selection from previous victim section

[ Upstream commit e219aecfd4b766c4e878a3769057e9809f7fcadc ]

When f2fs chooses GC victim in large section & LFS mode,
next_victim_seg[gc_type] is referenced first. After segment is freed,
next_victim_seg[gc_type] has the next segment number.
However, next_victim_seg[gc_type] still has the last segment number
even after the last segment of section is freed. In this case, when f2fs
chooses a victim for the next GC round, the last segment of previous victim
section is chosen as a victim.

Initialize next_victim_seg[gc_type] to NULL_SEGNO for the last segment in
large section.

Fixes: e3080b0120a1 ("f2fs: support subsectional garbage collection")
Signed-off-by: Yonggil Song <yonggil.song@samsung.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 4cbaa6ab083f07a34fed7e20648a196261a8625f..7863f8fd3b95ed32a1c23522e85e090fec40ad3d 100644 (file)
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -1673,8 +1673,9 @@ freed:
                                get_valid_blocks(sbi, segno, false) == 0)
                        seg_freed++;
 
-               if (__is_large_section(sbi) && segno + 1 < end_segno)
-                       sbi->next_victim_seg[gc_type] = segno + 1;
+               if (__is_large_section(sbi))
+                       sbi->next_victim_seg[gc_type] =
+                               (segno + 1 < end_segno) ? segno + 1 : NULL_SEGNO;
 skip:
                f2fs_put_page(sum_page, 0);
        }