firmware: qemu_fw_cfg: remove sysfs entries explicitly
authorJohan Hovold <johan@kernel.org>
Wed, 1 Dec 2021 13:25:28 +0000 (14:25 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Dec 2021 09:14:53 +0000 (10:14 +0100)
Explicitly remove the file entries from sysfs before dropping the final
reference for symmetry reasons and for consistency with the rest of the
driver.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20211201132528.30025-5-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/qemu_fw_cfg.c

index f08e056..b436342 100644 (file)
@@ -389,6 +389,7 @@ static void fw_cfg_sysfs_cache_cleanup(void)
 
        list_for_each_entry_safe(entry, next, &fw_cfg_entry_cache, list) {
                fw_cfg_sysfs_cache_delist(entry);
+               kobject_del(&entry->kobj);
                kobject_put(&entry->kobj);
        }
 }