journal: coding style fix
authorYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 15 Jan 2018 14:53:05 +0000 (23:53 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 15 Jan 2018 14:53:10 +0000 (23:53 +0900)
This is originally pointed out by @cpsw.

src/journal/journald-server.c

index 278f38f..74536e1 100644 (file)
@@ -464,13 +464,14 @@ static int do_rotate(
                 return -EINVAL;
 
         r = journal_file_rotate(f, s->compress, seal, s->deferred_closes);
-        if (r < 0)
+        if (r < 0) {
                 if (*f)
-                        log_error_errno(r, "Failed to rotate %s: %m", (*f)->path);
+                        return log_error_errno(r, "Failed to rotate %s: %m", (*f)->path);
                 else
-                        log_error_errno(r, "Failed to create new %s journal: %m", name);
-        else
-                server_add_acls(*f, uid);
+                        return log_error_errno(r, "Failed to create new %s journal: %m", name);
+        }
+
+        server_add_acls(*f, uid);
 
         return r;
 }