ACPI: sysfs: remove return value of acpi_device_setup_files()

The function can not fail anymore, so drop its return value.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://patch.msgid.link/20240709-acpi-sysfs-groups-v2-5-058ab0667fa8@weissschuh.net
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index 0bff4a1654ed469c1536af3c4e5456af78fa6c87..3961fc47152c0affce1956df2a833e432cc87517 100644 (file)
--- a/drivers/acpi/device_sysfs.c
+++ b/drivers/acpi/device_sysfs.c
@@ -605,13 +605,9 @@ const struct attribute_group *acpi_groups[] = {
  * acpi_device_setup_files - Create sysfs attributes of an ACPI device.
  * @dev: ACPI device object.
  */
-int acpi_device_setup_files(struct acpi_device *dev)
+void acpi_device_setup_files(struct acpi_device *dev)
 {
-       int result = 0;
-
        acpi_expose_nondev_subnodes(&dev->dev.kobj, &dev->data);
-
-       return result;
 }
 
 /**

diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
index 8e1c21e45d0e4fc2861a841b518533dec6f42c10..ca712a7fde216d00af9d03937145ccc98dd4cf4c 100644 (file)
--- a/drivers/acpi/internal.h
+++ b/drivers/acpi/internal.h
@@ -118,7 +118,7 @@ void acpi_init_device_object(struct acpi_device *device, acpi_handle handle,
                             int type, void (*release)(struct device *));
 int acpi_tie_acpi_dev(struct acpi_device *adev);
 int acpi_device_add(struct acpi_device *device);
-int acpi_device_setup_files(struct acpi_device *dev);
+void acpi_device_setup_files(struct acpi_device *dev);
 void acpi_device_remove_files(struct acpi_device *dev);
 extern const struct attribute_group *acpi_groups[];
 void acpi_device_add_finalize(struct acpi_device *device);

diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 14dba8f6faffd84841e29dd1129b7e81a7d6f696..494f4f503e5b3034a421d074b2e0108dfc443227 100644 (file)
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -795,10 +795,7 @@ int acpi_device_add(struct acpi_device *device)
                goto err;
        }
 
-       result = acpi_device_setup_files(device);
-       if (result)
-               pr_err("Error creating sysfs interface for device %s\n",
-                      dev_name(&device->dev));
+       acpi_device_setup_files(device);
 
        return 0;