ext4: use is_power_of_2 helper in ext4_mb_regular_allocator
authorKemeng Shi <shikemeng@huaweicloud.com>
Tue, 1 Aug 2023 14:31:58 +0000 (22:31 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 3 Aug 2023 14:47:30 +0000 (10:47 -0400)
Use intuitive is_power_of_2 helper in ext4_mb_regular_allocator.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/20230801143204.2284343-5-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/mballoc.c

index 880b973..3dd2609 100644 (file)
@@ -2799,10 +2799,7 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac)
         * requests upto maximum buddy size we have constructed.
         */
        if (i >= sbi->s_mb_order2_reqs && i <= MB_NUM_ORDERS(sb)) {
-               /*
-                * This should tell if fe_len is exactly power of 2
-                */
-               if ((ac->ac_g_ex.fe_len & (~(1 << (i - 1)))) == 0)
+               if (is_power_of_2(ac->ac_g_ex.fe_len))
                        ac->ac_2order = array_index_nospec(i - 1,
                                                           MB_NUM_ORDERS(sb));
        }