staging: rtl8723bs: remove typedefs in hal_com_h2c.h
authorMarco Cesati <marcocesati@gmail.com>
Fri, 12 Mar 2021 08:26:24 +0000 (09:26 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 12 Mar 2021 16:25:40 +0000 (17:25 +0100)
This commit fixes the following checkpatch.pl warning:

    WARNING: do not add new typedefs
    #251: FILE: include/hal_com_h2c.h:251:
    +typedef struct _RSVDPAGE_LOC {

Signed-off-by: Marco Cesati <marco.cesati@gmail.com>
Link: https://lore.kernel.org/r/20210312082638.25512-20-marco.cesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
drivers/staging/rtl8723bs/include/hal_com_h2c.h

index 86f31d9..515b56a 100644 (file)
@@ -832,7 +832,7 @@ void CheckFwRsvdPageContent(struct adapter *Adapter)
 {
 }
 
-static void rtl8723b_set_FwRsvdPage_cmd(struct adapter *padapter, PRSVDPAGE_LOC rsvdpageloc)
+static void rtl8723b_set_FwRsvdPage_cmd(struct adapter *padapter, struct RSVDPAGE_LOC *rsvdpageloc)
 {
        u8 u1H2CRsvdPageParm[H2C_RSVDPAGE_LOC_LEN] = {0};
 
@@ -851,7 +851,7 @@ static void rtl8723b_set_FwRsvdPage_cmd(struct adapter *padapter, PRSVDPAGE_LOC
        FillH2CCmd8723B(padapter, H2C_8723B_RSVD_PAGE, H2C_RSVDPAGE_LOC_LEN, u1H2CRsvdPageParm);
 }
 
-static void rtl8723b_set_FwAoacRsvdPage_cmd(struct adapter *padapter, PRSVDPAGE_LOC rsvdpageloc)
+static void rtl8723b_set_FwAoacRsvdPage_cmd(struct adapter *padapter, struct RSVDPAGE_LOC *rsvdpageloc)
 {
 #ifdef CONFIG_WOWLAN
        struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -891,7 +891,7 @@ static void rtl8723b_set_FwAoacRsvdPage_cmd(struct adapter *padapter, PRSVDPAGE_
 
 #ifdef CONFIG_AP_WOWLAN
 static void rtl8723b_set_ap_wow_rsvdpage_cmd(
-       struct adapter *padapter, PRSVDPAGE_LOC rsvdpageloc
+       struct adapter *padapter, struct RSVDPAGE_LOC *rsvdpageloc
 )
 {
        u8 header;
@@ -1284,7 +1284,7 @@ static void rtl8723b_set_FwAOACGlobalInfo_Cmd(struct adapter *padapter,  u8 grou
 }
 
 #ifdef CONFIG_PNO_SUPPORT
-static void rtl8723b_set_FwScanOffloadInfo_cmd(struct adapter *padapter, PRSVDPAGE_LOC rsvdpageloc, u8 enable)
+static void rtl8723b_set_FwScanOffloadInfo_cmd(struct adapter *padapter, struct RSVDPAGE_LOC *rsvdpageloc, u8 enable)
 {
        u8 u1H2CScanOffloadInfoParm[H2C_SCAN_OFFLOAD_CTRL_LEN] = {0};
 
@@ -1444,7 +1444,7 @@ static void rtl8723b_set_FwRsvdPagePkt(
        u8 TotalPageNum = 0, CurtPktPageNum = 0, RsvdPageNum = 0;
        u16 BufIndex, PageSize = 128;
        u32 TotalPacketLen, MaxRsvdPageBufSize = 0;
-       RSVDPAGE_LOC RsvdPageLoc;
+       struct RSVDPAGE_LOC RsvdPageLoc;
 #ifdef CONFIG_WOWLAN
        u32 ARPLegnth = 0, GTKLegnth = 0;
        u8 currentip[4];
@@ -1474,7 +1474,7 @@ static void rtl8723b_set_FwRsvdPagePkt(
        }
 
        ReservedPagePacket = pcmdframe->buf_addr;
-       memset(&RsvdPageLoc, 0, sizeof(RSVDPAGE_LOC));
+       memset(&RsvdPageLoc, 0, sizeof(struct RSVDPAGE_LOC));
 
        /* 3 (1) beacon */
        BufIndex = TxDescOffset;
@@ -1829,7 +1829,7 @@ static void rtl8723b_set_AP_FwRsvdPagePkt(
        u8 currentip[4];
        u16 BufIndex, PageSize = 128;
        u32 TotalPacketLen = 0, MaxRsvdPageBufSize = 0;
-       RSVDPAGE_LOC RsvdPageLoc;
+       struct RSVDPAGE_LOC RsvdPageLoc;
 
        /* DBG_871X("%s---->\n", __func__); */
        DBG_8192C("+" FUNC_ADPT_FMT ": iface_type =%d\n",
@@ -1851,7 +1851,7 @@ static void rtl8723b_set_AP_FwRsvdPagePkt(
        }
 
        ReservedPagePacket = pcmdframe->buf_addr;
-       memset(&RsvdPageLoc, 0, sizeof(RSVDPAGE_LOC));
+       memset(&RsvdPageLoc, 0, sizeof(struct RSVDPAGE_LOC));
 
        /* 3 (1) beacon */
        BufIndex = TxDescOffset;
@@ -2136,7 +2136,7 @@ static void SetFwRsvdPagePkt_BTCoex(struct adapter *padapter)
        u8 TotalPageNum = 0, CurtPktPageNum = 0, RsvdPageNum = 0;
        u16 BufIndex, PageSize;
        u32 TotalPacketLen, MaxRsvdPageBufSize = 0;
-       RSVDPAGE_LOC RsvdPageLoc;
+       struct RSVDPAGE_LOC RsvdPageLoc;
 
 
 /*     DBG_8192C("+" FUNC_ADPT_FMT "\n", FUNC_ADPT_ARG(padapter)); */
@@ -2156,7 +2156,7 @@ static void SetFwRsvdPagePkt_BTCoex(struct adapter *padapter)
        }
 
        ReservedPagePacket = pcmdframe->buf_addr;
-       memset(&RsvdPageLoc, 0, sizeof(RSVDPAGE_LOC));
+       memset(&RsvdPageLoc, 0, sizeof(struct RSVDPAGE_LOC));
 
        /* 3 (1) beacon */
        BufIndex = TxDescOffset;
index b951bc2..8970c59 100644 (file)
@@ -248,7 +248,7 @@ enum h2c_cmd {
 /*  */
 /*     Structure    -------------------------------------------------- */
 /*  */
-typedef struct _RSVDPAGE_LOC {
+struct RSVDPAGE_LOC {
        u8 LocProbeRsp;
        u8 LocPsPoll;
        u8 LocNullData;
@@ -275,7 +275,7 @@ typedef struct _RSVDPAGE_LOC {
 #ifdef CONFIG_AP_WOWLAN
        u8 LocApOffloadBCN;
 #endif /* CONFIG_AP_WOWLAN */
-} RSVDPAGE_LOC, *PRSVDPAGE_LOC;
+};
 
 #endif
 #if defined(CONFIG_WOWLAN) || defined(CONFIG_AP_WOWLAN)