s390/qeth: modernize two list helpers
authorJulian Wiedmann <jwi@linux.ibm.com>
Wed, 25 Mar 2020 09:35:07 +0000 (10:35 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 25 Mar 2020 19:07:16 +0000 (12:07 -0700)
Replace list_for_each() with list_for_each_entry(), and
list_entry(head.next) with list_first_entry().

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core_main.c

index 8713f1b..d06d9f8 100644 (file)
@@ -2629,15 +2629,13 @@ static void qeth_initialize_working_pool_list(struct qeth_card *card)
 static struct qeth_buffer_pool_entry *qeth_find_free_buffer_pool_entry(
                                        struct qeth_card *card)
 {
-       struct list_head *plh;
        struct qeth_buffer_pool_entry *entry;
        int i, free;
 
        if (list_empty(&card->qdio.in_buf_pool.entry_list))
                return NULL;
 
-       list_for_each(plh, &card->qdio.in_buf_pool.entry_list) {
-               entry = list_entry(plh, struct qeth_buffer_pool_entry, list);
+       list_for_each_entry(entry, &card->qdio.in_buf_pool.entry_list, list) {
                free = 1;
                for (i = 0; i < QETH_MAX_BUFFER_ELEMENTS(card); ++i) {
                        if (page_count(entry->elements[i]) > 1) {
@@ -2652,8 +2650,8 @@ static struct qeth_buffer_pool_entry *qeth_find_free_buffer_pool_entry(
        }
 
        /* no free buffer in pool so take first one and swap pages */
-       entry = list_entry(card->qdio.in_buf_pool.entry_list.next,
-                       struct qeth_buffer_pool_entry, list);
+       entry = list_first_entry(&card->qdio.in_buf_pool.entry_list,
+                                struct qeth_buffer_pool_entry, list);
        for (i = 0; i < QETH_MAX_BUFFER_ELEMENTS(card); ++i) {
                if (page_count(entry->elements[i]) > 1) {
                        struct page *page = dev_alloc_page();