media: i2c: ov7670: Use the devm_clk_get_optional() helper
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 26 Mar 2023 14:21:16 +0000 (16:21 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Tue, 11 Apr 2023 16:54:00 +0000 (18:54 +0200)
Use devm_clk_get_optional() instead of hand writing it.
This saves some loC and improves the semantic.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/i2c/ov7670.c

index b1bb083..ecbded4 100644 (file)
@@ -1894,14 +1894,9 @@ static int ov7670_probe(struct i2c_client *client)
                        info->pclk_hb_disable = true;
        }
 
-       info->clk = devm_clk_get(&client->dev, "xclk"); /* optional */
-       if (IS_ERR(info->clk)) {
-               ret = PTR_ERR(info->clk);
-               if (ret == -ENOENT)
-                       info->clk = NULL;
-               else
-                       return ret;
-       }
+       info->clk = devm_clk_get_optional(&client->dev, "xclk");
+       if (IS_ERR(info->clk))
+               return PTR_ERR(info->clk);
 
        ret = ov7670_init_gpio(client, info);
        if (ret)