Use pass by reference instead of by value

* This patch fixes Svace issue

Change-Id: I5b276f2cac8c9703e218e2262a06eb827f3ee06b
Signed-off-by: Boram Bae <boram21.bae@samsung.com>

diff --git a/.gitignore b/.gitignore
index ca9cbd7ff296d569234178c5261497d49d93ff25..fa43b1a7049e4935c76d4deb503df367ce600beb 100644 (file)
--- a/.gitignore
+++ b/.gitignore
@@ -2,3 +2,4 @@
 .cproject
 .*.swp
 nbproject
+.vscode
\ No newline at end of file

diff --git a/src/fusion-sensor/rotation_vector/fusion_utils/matrix.cpp b/src/fusion-sensor/rotation_vector/fusion_utils/matrix.cpp
index 2b1c1773dae926fe1ad554bcd5e3cd37ae98381c..ad584da5049c16ea60961903de68884f10a0831a 100644 (file)
--- a/src/fusion-sensor/rotation_vector/fusion_utils/matrix.cpp
+++ b/src/fusion-sensor/rotation_vector/fusion_utils/matrix.cpp
@@ -26,7 +26,7 @@ TYPE_ROW_COL matrix<TYPE, ROW, COL>::matrix(void)
                        m_mat[i][j] = 0;
 }
 
-TYPE_ROW_COL matrix<TYPE, ROW, COL>::matrix(const matrix<TYPE, ROW, COL>& m)
+TYPE_ROW_COL matrix<TYPE, ROW, COL>::matrix(const matrix<TYPE, ROW, COL> &m)
 {
        for (int p = 0; p < ROW; p++)
                for (int q = 0; q < COL; q++)
@@ -44,7 +44,7 @@ TYPE_ROW_COL matrix<TYPE, ROW, COL>::~matrix()
 {
 }
 
-TYPE_ROW_COL matrix<TYPE, ROW, COL> matrix<TYPE, ROW, COL>::operator =(const matrix<TYPE, ROW, COL>& m)
+TYPE_ROW_COL matrix<TYPE, ROW, COL> matrix<TYPE, ROW, COL>::operator =(const matrix<TYPE, ROW, COL> &m)
 {
        if (this == &m)
        {
@@ -58,7 +58,7 @@ TYPE_ROW_COL matrix<TYPE, ROW, COL> matrix<TYPE, ROW, COL>::operator =(const mat
        return *this;
 }
 
-T_R_C ostream& operator <<(ostream& dout, matrix<T, R, C>& m)
+T_R_C ostream& operator <<(ostream& dout, matrix<T, R, C> &m)
 {
        for (int i = 0; i < R; i++)
        {
@@ -71,7 +71,7 @@ T_R_C ostream& operator <<(ostream& dout, matrix<T, R, C>& m)
        return dout;
 }
 
-T_R_C matrix<T, R, C> operator +(const matrix<T, R, C> m1, const matrix<T, R, C> m2)
+T_R_C matrix<T, R, C> operator +(const matrix<T, R, C> &m1, const matrix<T, R, C> &m2)
 {
        matrix<T, R, C> m3;
 
@@ -82,7 +82,7 @@ T_R_C matrix<T, R, C> operator +(const matrix<T, R, C> m1, const matrix<T, R, C>
        return m3;
 }
 
-T_R_C matrix<T, R, C> operator +(const matrix<T, R, C> m, const T val)
+T_R_C matrix<T, R, C> operator +(const matrix<T, R, C> &m, const T &val)
 {
        matrix<T, R, C> m1;
 
@@ -93,7 +93,7 @@ T_R_C matrix<T, R, C> operator +(const matrix<T, R, C> m, const T val)
        return m1;
 }
 
-T_R_C matrix<T, R, C> operator -(const matrix<T, R, C> m1, const matrix<T, R, C> m2)
+T_R_C matrix<T, R, C> operator -(const matrix<T, R, C> &m1, const matrix<T, R, C> &m2)
 {
        matrix<T, R, C> m3;
 
@@ -104,7 +104,7 @@ T_R_C matrix<T, R, C> operator -(const matrix<T, R, C> m1, const matrix<T, R, C>
        return m3;
 }
 
-T_R_C matrix<T, R, C> operator -(const matrix<T, R, C> m, const T val)
+T_R_C matrix<T, R, C> operator -(const matrix<T, R, C> &m, const T &val)
 {
        matrix<T, R, C> m1;
 
@@ -115,7 +115,7 @@ T_R_C matrix<T, R, C> operator -(const matrix<T, R, C> m, const T val)
        return m1;
 }
 
-T_R_C_C2 matrix<T, R, C2> operator *(const matrix<T, R, C> m1, const matrix<T, C, C2> m2)
+T_R_C_C2 matrix<T, R, C2> operator *(const matrix<T, R, C> &m1, const matrix<T, C, C2> &m2)
 {
        matrix<T, R, C2> m3;
 
@@ -132,7 +132,7 @@ T_R_C_C2 matrix<T, R, C2> operator *(const matrix<T, R, C> m1, const matrix<T, C
        return m3;
 }
 
-T_R_C matrix<T, R, C> operator *(const matrix<T, R, C> m, const T val)
+T_R_C matrix<T, R, C> operator *(const matrix<T, R, C> &m, const T &val)
 {
        matrix<T, R, C> m1;
 
@@ -143,7 +143,7 @@ T_R_C matrix<T, R, C> operator *(const matrix<T, R, C> m, const T val)
        return m1;
 }
 
-T_R_C matrix<T, R, C> operator /(const matrix<T, R, C> m1, const T val)
+T_R_C matrix<T, R, C> operator /(const matrix<T, R, C> &m1, const T &val)
 {
        matrix<T, R, C> m3;
 
@@ -154,7 +154,7 @@ T_R_C matrix<T, R, C> operator /(const matrix<T, R, C> m1, const T val)
        return m3;
 }
 
-T_R1_C1_R2_C2 bool operator ==(const matrix<T, R1, C1> m1, const matrix<T, R2, C2> m2)
+T_R1_C1_R2_C2 bool operator ==(const matrix<T, R1, C1> &m1, const matrix<T, R2, C2> &m2)
 {
        if ((R1 == R2) && (C1 == C2)) {
                for (int i = 0; i < R1; i++)
@@ -167,12 +167,12 @@ T_R1_C1_R2_C2 bool operator ==(const matrix<T, R1, C1> m1, const matrix<T, R2, C
        return false;
 }
 
-T_R1_C1_R2_C2 bool operator !=(const matrix<T, R1, C1> m1, const matrix<T, R2, C2> m2)
+T_R1_C1_R2_C2 bool operator !=(const matrix<T, R1, C1> &m1, const matrix<T, R2, C2> &m2)
 {
        return (!(m1 == m2));
 }
 
-T_R_C matrix<T, R, C> tran(const matrix<T, R, C> m)
+T_R_C matrix<T, R, C> tran(const matrix<T, R, C> &m)
 {
        matrix<T, R, C> m1;
 

diff --git a/src/fusion-sensor/rotation_vector/fusion_utils/matrix.h b/src/fusion-sensor/rotation_vector/fusion_utils/matrix.h
index b2c47bbda98bddbd379b8d434375ef102e266c85..bed7754ea1614217d09849fc14cf596bad562928 100644 (file)
--- a/src/fusion-sensor/rotation_vector/fusion_utils/matrix.h
+++ b/src/fusion-sensor/rotation_vector/fusion_utils/matrix.h
@@ -38,19 +38,19 @@ public:
        matrix(const matrix<TYPE, ROW, COL>& m);
        ~matrix();
 
-       matrix<TYPE, ROW, COL> operator =(const matrix<TYPE, ROW, COL>& m);
-
-       T_R_C friend ostream& operator << (ostream& dout, matrix<T, R, C>& m);
-       T_R_C friend matrix<T, R, C> operator +(const matrix<T, R, C> m1, const matrix<T, R, C> m2);
-       T_R_C friend matrix<T, R, C> operator +(const matrix<T, R, C> m, const T val);
-       T_R_C friend matrix<T, R, C> operator -(const matrix<T, R, C> m1, const matrix<T, R, C> m2);
-       T_R_C friend matrix<T, R, C> operator -(const matrix<T, R, C> m, const T val);
-       T_R_C_C2 friend matrix<T, R, C2> operator *(const matrix<T, R, C> m1, const matrix<T, C, C2> m2);
-       T_R_C friend matrix<T, R, C> operator *(const matrix<T, R, C> m, const T val);
-       T_R_C friend matrix<T, R, C> operator /(const matrix<T, R, C> m1, const T val);
-       T_R1_C1_R2_C2 friend bool operator ==(const matrix<T, R1, C1> m1, const matrix<T, R2, C2> m2);
-       T_R1_C1_R2_C2 friend bool operator !=(const matrix<T, R1, C1> m1, const matrix<T, R2, C2> m2);
-       T_R_C friend matrix<T, R, C> tran(const matrix<T, R, C> m);
+       matrix<TYPE, ROW, COL> operator =(const matrix<TYPE, ROW, COL> &m);
+
+       T_R_C friend ostream& operator << (ostream& dout, matrix<T, R, C> &m);
+       T_R_C friend matrix<T, R, C> operator +(const matrix<T, R, C> &m1, const matrix<T, R, C> &m2);
+       T_R_C friend matrix<T, R, C> operator +(const matrix<T, R, C> &m, const T &val);
+       T_R_C friend matrix<T, R, C> operator -(const matrix<T, R, C> &m1, const matrix<T, R, C> &m2);
+       T_R_C friend matrix<T, R, C> operator -(const matrix<T, R, C> &m, const T &val);
+       T_R_C_C2 friend matrix<T, R, C2> operator *(const matrix<T, R, C> &m1, const matrix<T, C, C2> &m2);
+       T_R_C friend matrix<T, R, C> operator *(const matrix<T, R, C> &m, const T &val);
+       T_R_C friend matrix<T, R, C> operator /(const matrix<T, R, C> &m1, const T &val);
+       T_R1_C1_R2_C2 friend bool operator ==(const matrix<T, R1, C1> &m1, const matrix<T, R2, C2> &m2);
+       T_R1_C1_R2_C2 friend bool operator !=(const matrix<T, R1, C1> &m1, const matrix<T, R2, C2> &m2);
+       T_R_C friend matrix<T, R, C> tran(const matrix<T, R, C> &m);
 };
 
 #include "matrix.cpp"