selftests/landlock: Add tests for O_PATH
authorMickaël Salaün <mic@digikod.net>
Fri, 6 May 2022 16:08:17 +0000 (18:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:23:23 +0000 (10:23 +0200)
commit d1788ad990874734341b05ab8ccb6448c09c6422 upstream.

The O_PATH flag is currently not handled by Landlock.  Let's make sure
this behavior will remain consistent with the same ruleset over time.

Cc: Shuah Khan <shuah@kernel.org>
Link: https://lore.kernel.org/r/20220506160820.524344-8-mic@digikod.net
Cc: stable@vger.kernel.org
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/testing/selftests/landlock/fs_test.c

index 9165f6a..a8f54c4 100644 (file)
@@ -654,17 +654,23 @@ TEST_F_FORK(layout1, effective_access)
        enforce_ruleset(_metadata, ruleset_fd);
        ASSERT_EQ(0, close(ruleset_fd));
 
-       /* Tests on a directory. */
+       /* Tests on a directory (with or without O_PATH). */
        ASSERT_EQ(EACCES, test_open("/", O_RDONLY));
+       ASSERT_EQ(0, test_open("/", O_RDONLY | O_PATH));
        ASSERT_EQ(EACCES, test_open(dir_s1d1, O_RDONLY));
+       ASSERT_EQ(0, test_open(dir_s1d1, O_RDONLY | O_PATH));
        ASSERT_EQ(EACCES, test_open(file1_s1d1, O_RDONLY));
+       ASSERT_EQ(0, test_open(file1_s1d1, O_RDONLY | O_PATH));
+
        ASSERT_EQ(0, test_open(dir_s1d2, O_RDONLY));
        ASSERT_EQ(0, test_open(file1_s1d2, O_RDONLY));
        ASSERT_EQ(0, test_open(dir_s1d3, O_RDONLY));
        ASSERT_EQ(0, test_open(file1_s1d3, O_RDONLY));
 
-       /* Tests on a file. */
+       /* Tests on a file (with or without O_PATH). */
        ASSERT_EQ(EACCES, test_open(dir_s2d2, O_RDONLY));
+       ASSERT_EQ(0, test_open(dir_s2d2, O_RDONLY | O_PATH));
+
        ASSERT_EQ(0, test_open(file1_s2d2, O_RDONLY));
 
        /* Checks effective read and write actions. */