gobex: Fix read from pointer after free
authorTedd Ho-Jeong An <tedd.an@intel.com>
Fri, 18 Feb 2022 19:46:17 +0000 (11:46 -0800)
committerAyush Garg <ayush.garg@samsung.com>
Mon, 15 May 2023 09:25:53 +0000 (14:55 +0530)
This patch sets the pointer to null after free since the g_free(p)
doesn't set the pointer to NULL.

This is reported by the Coverity.

Fixes: 7e7d826aa1db ("gobex: Print error if data cannot be written")
Signed-off-by: Manika Shrivastava <manika.sh@samsung.com>
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
gobex/gobex.c

index e2916e2..0c35af9 100644 (file)
@@ -471,6 +471,8 @@ encode:
                                check_srm_final(obex,
                                                obex->tx_buf[0] & ~FINAL_BIT);
                        pending_pkt_free(p);
+                       /* g_free() doesn't set the pointer to NULL */
+                       p = NULL;
                }
 
                obex->tx_data = len;