Staging: hp: Use netdev_warn().
authorSam Muhammed <jane.pnx9@gmail.com>
Sun, 22 Mar 2020 11:50:51 +0000 (07:50 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Mar 2020 10:41:02 +0000 (11:41 +0100)
This replaces printk(KERN_WARNING ..) with netdev_warn(),
as the use of printk() isn't preferred when
a struct net_device is available.

Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
Acked-by: Julia Lawall <julia.lawall@inria.fr>
Link: https://lore.kernel.org/r/20200322115051.2767-1-jane.pnx9@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/hp/hp100.c

index b89c4dc..c1f5506 100644 (file)
@@ -469,8 +469,8 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus,
 
        eid = hp100_read_id(ioaddr);
        if (eid == NULL) {      /* bad checksum? */
-               printk(KERN_WARNING "%s: bad ID checksum at base port 0x%x\n",
-                      __func__, ioaddr);
+               netdev_warn(dev, "bad ID checksum at base port 0x%x\n",
+                           ioaddr);
                goto out2;
        }
 
@@ -478,9 +478,9 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus,
        for (i = uc = 0; i < 7; i++)
                uc += hp100_inb(LAN_ADDR + i);
        if (uc != 0xff) {
-               printk(KERN_WARNING
-                      "%s: bad lan address checksum at port 0x%x)\n",
-                      __func__, ioaddr);
+               netdev_warn(dev,
+                           "bad lan address checksum at port 0x%x)\n",
+                           ioaddr);
                err = -EIO;
                goto out2;
        }