ARM: at91: pm: Add of_node_put() before goto
authorWan Jiabing <wanjiabing@vivo.com>
Thu, 14 Oct 2021 08:45:55 +0000 (04:45 -0400)
committerNicolas Ferre <nicolas.ferre@microchip.com>
Wed, 8 Dec 2021 13:01:16 +0000 (14:01 +0100)
Fix following coccicheck warning:
./arch/arm/mach-at91/pm.c:643:1-33: WARNING: Function
for_each_matching_node_and_match should have of_node_put() before goto

Early exits from for_each_matching_node_and_match should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20211014084555.21422-1-wanjiabing@vivo.com
arch/arm/mach-at91/pm.c

index 8711d68..dd6f4ce 100644 (file)
@@ -645,6 +645,7 @@ static __init int at91_dt_ramc(bool phy_mandatory)
                if (!soc_pm.data.ramc[idx]) {
                        pr_err("unable to map ramc[%d] cpu registers\n", idx);
                        ret = -ENOMEM;
+                       of_node_put(np);
                        goto unmap_ramc;
                }
 
@@ -670,6 +671,7 @@ static __init int at91_dt_ramc(bool phy_mandatory)
                if (!soc_pm.data.ramc_phy) {
                        pr_err("unable to map ramc phy cpu registers\n");
                        ret = -ENOMEM;
+                       of_node_put(np);
                        goto unmap_ramc;
                }
        }