Wrap verify file id condition in Check call (#6085)
authorNavin Mohan <navinmohan81@gmail.com>
Mon, 31 Aug 2020 18:32:13 +0000 (00:02 +0530)
committerGitHub <noreply@github.com>
Mon, 31 Aug 2020 18:32:13 +0000 (11:32 -0700)
Run clang-format

Update testcase

include/flatbuffers/flatbuffers.h
tests/test.cpp

index ca5c658..47d6f1b 100644 (file)
@@ -2274,8 +2274,8 @@ class Verifier FLATBUFFERS_FINAL_CLASS {
 
   template<typename T>
   bool VerifyBufferFromStart(const char *identifier, size_t start) {
-    if (identifier && (size_ < 2 * sizeof(flatbuffers::uoffset_t) ||
-                       !BufferHasIdentifier(buf_ + start, identifier))) {
+    if (identifier && !Check((size_ >= 2 * sizeof(flatbuffers::uoffset_t) &&
+                              BufferHasIdentifier(buf_ + start, identifier)))) {
       return false;
     }
 
index 86f13d2..8701b6b 100644 (file)
@@ -3218,7 +3218,7 @@ void FixedLengthArrayTest() {
   aStruct.mutable_d()->Mutate(0, nStruct0);
   aStruct.mutable_d()->Mutate(1, nStruct1);
   auto aTable = MyGame::Example::CreateArrayTable(fbb, &aStruct);
-  fbb.Finish(aTable);
+  MyGame::Example::FinishArrayTableBuffer(fbb, aTable);
 
   // Verify correctness of the ArrayTable.
   flatbuffers::Verifier verifier(fbb.GetBufferPointer(), fbb.GetSize());