Fix Prevent issue
authorZbigniew Kostrzewa <z.kostrzewa@samsung.com>
Thu, 3 Oct 2013 05:20:42 +0000 (07:20 +0200)
committerHoseon LEE <hoseon46.lee@samsung.com>
Mon, 14 Oct 2013 11:19:59 +0000 (20:19 +0900)
[Issue#]   CID: 33265
[Problem]  Resource leak.
[Cause]    Allocated memory is not released.
[Solution] Fix the code so that allocated memory is assigned to pointer
           from outer scope which is passed to the EVAS_CALLBACK_DEL callback
           (in which the memory is released).

[Verification]
    1. Build repository
    2. Run a test that will display pop-up from security origin.

Change-Id: Ic03284cb9b696e4d5aa8329d081700d2bd086381

src/view/common/view_logic_certificate_support.cpp
src/view/common/view_logic_security_origin_support.cpp

index a4291e8..9cd535e 100644 (file)
@@ -173,7 +173,7 @@ Evas_Object* CertificateSupportUtil::createPopup(
 
     CallbackData* callbackData = NULL;
     if (keyCallback) {
-        CallbackData* callbackData = new CallbackData;
+        callbackData = new CallbackData;
         callbackData->eaKeyCallback = keyCallback;
         ea_object_event_callback_add(popup, EA_CALLBACK_BACK, keyCallback, data);
     }
index dcebefc..fcb98bd 100644 (file)
@@ -169,7 +169,7 @@ Evas_Object* SecurityOriginSupportUtil::createPopup(
 
     CallbackData* callbackData = NULL;
     if (keyCallback) {
-        CallbackData* callbackData = new CallbackData;
+        callbackData = new CallbackData;
         callbackData->eaKeyCallback = keyCallback;
         ea_object_event_callback_add(popup, EA_CALLBACK_BACK, keyCallback, data);
     }