9p/net: fix memory leak in p9_client_create
authorzhengbin <zhengbin13@huawei.com>
Wed, 13 Mar 2019 08:01:37 +0000 (16:01 +0800)
committerDominique Martinet <dominique.martinet@cea.fr>
Wed, 13 Mar 2019 10:50:04 +0000 (11:50 +0100)
If msize is less than 4096, we should close and put trans, destroy
tagpool, not just free client. This patch fixes that.

Link: http://lkml.kernel.org/m/1552464097-142659-1-git-send-email-zhengbin13@huawei.com
Cc: stable@vger.kernel.org
Fixes: 574d356b7a02 ("9p/net: put a lower bound on msize")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
net/9p/client.c

index 357214a..b85d51f 100644 (file)
@@ -1061,7 +1061,7 @@ struct p9_client *p9_client_create(const char *dev_name, char *options)
                p9_debug(P9_DEBUG_ERROR,
                         "Please specify a msize of at least 4k\n");
                err = -EINVAL;
-               goto free_client;
+               goto close_trans;
        }
 
        err = p9_client_version(clnt);