USB: legousbtower: stop interrupt-out URB unconditionally
authorJohan Hovold <johan@kernel.org>
Tue, 5 Nov 2019 08:41:45 +0000 (09:41 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 Nov 2019 10:17:51 +0000 (11:17 +0100)
Stop also the interrupt-out URB unconditionally in
tower_abort_transfers() which is called from release() (for connected
devices). Calling usb_kill_urb() for an idle URB is perfectly fine.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191105084152.16322-8-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/legousbtower.c

index 33533fa..3e409df 100644 (file)
@@ -448,8 +448,7 @@ static void tower_abort_transfers (struct lego_usb_tower *dev)
 {
        /* shutdown transfer */
        usb_kill_urb(dev->interrupt_in_urb);
-       if (dev->interrupt_out_busy)
-               usb_kill_urb(dev->interrupt_out_urb);
+       usb_kill_urb(dev->interrupt_out_urb);
 }