f2fs: avoid memory leak in f2fs_write_root_inode
authorChao Yu <yuchao0@huawei.com>
Thu, 16 Nov 2017 11:50:57 +0000 (19:50 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Mon, 27 Nov 2017 04:21:58 +0000 (20:21 -0800)
Before exiting f2fs_write_root_inode, we should free in-there allocated
memory.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
mkfs/f2fs_format.c

index d5f39ca..9fc0398 100644 (file)
@@ -1042,6 +1042,7 @@ static int f2fs_write_root_inode(void)
                        c.blks_per_seg, main_area_node_seg_blk_offset);
        if (dev_write_block(raw_node, main_area_node_seg_blk_offset)) {
                MSG(1, "\tError: While writing the raw_node to disk!!!\n");
+               free(raw_node);
                return -1;
        }
 
@@ -1052,9 +1053,11 @@ static int f2fs_write_root_inode(void)
 
 #ifndef WITH_ANDROID
        if (discard_obsolete_dnode(raw_node, main_area_node_seg_blk_offset)) {
+               free(raw_node);
                return -1;
        }
 #endif
+       free(raw_node);
        return 0;
 }