ALSA: gus: Replace unsafe strcpy() with strscpy()

Fix smatch warning:
sound/isa/gus/gus_main.c:396 snd_gus_check_version() error:
 strcpy() 'card->longname' too large for 'card->shortname' (80 vs 32)

Even if this is not a real bug since the longest length of card->longname
now is 31, replace strcpy() with strscpy() in order to avoid possible
future mistake.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20210514070507.16600-1-yuehaibing@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/isa/gus/gus_main.c b/sound/isa/gus/gus_main.c
index afc088f..46bfc5a 100644 (file)
--- a/sound/isa/gus/gus_main.c
+++ b/sound/isa/gus/gus_main.c
@@ -393,7 +393,7 @@ static int snd_gus_check_version(struct snd_gus_card * gus)
                        }
                }
        }
-       strcpy(card->shortname, card->longname);
+       strscpy(card->shortname, card->longname, sizeof(card->shortname));
        gus->uart_enable = 1;   /* standard GUSes doesn't have midi uart trouble */
        snd_gus_init_control(gus);
        return 0;