Fixed some potential issues. 00/173700/1 accepted/tizen/unified/20180326.075301 submit/tizen/20180323.075654
authorjoonbum.ko <joonbum.ko@samsung.com>
Fri, 23 Mar 2018 07:47:18 +0000 (16:47 +0900)
committerjoonbum.ko <joonbum.ko@samsung.com>
Fri, 23 Mar 2018 07:47:21 +0000 (16:47 +0900)
 - WGID : 305119
  null-driver : NONTERMINATED_STRING
 - WGID : 305122
  samples/tri.c : DEREF_AFTER_NULL

Change-Id: I11ed1b1e05bb514c401793602dc81df064536379
Signed-off-by: joonbum.ko <joonbum.ko@samsung.com>
samples/tri.c
src/null-driver/null-driver.c

index 36560d1..df4734b 100644 (file)
@@ -1792,7 +1792,6 @@ static void demo_create_window(struct demo *demo) {
        }
 
        wl_surface_set_user_data(demo->wl_surface, demo);
-       wl_shell_surface_set_title(demo->shell_surface, APP_SHORT_NAME);
 }
 #endif // _WIN32
 
index cc91a43..12b8b8d 100644 (file)
@@ -29,6 +29,7 @@
  */
 
 #include "null-driver.h"
+#include <stdio.h>
 #include <stdbool.h>
 #include <stdlib.h>
 #include <string.h>
@@ -1458,9 +1459,7 @@ get_physical_device_properties(VkPhysicalDevice pdev,
        props->vendorID = 0;
        props->deviceID = 0;
        props->deviceType = VK_PHYSICAL_DEVICE_TYPE_OTHER;
-       strncpy(props->deviceName, "nulldrv", strlen("nulldrv"));
-       if (strlen("nulldrv") < VK_MAX_PHYSICAL_DEVICE_NAME_SIZE)
-               props->deviceName[strlen("nulldrv")] = '\0';
+       snprintf(props->deviceName, strlen("nulldrv") + 1, "nulldrv");
 
        /* TODO: fill out limits */
        memset(&props->limits, 0, sizeof(VkPhysicalDeviceLimits));