i2c: ocores: use request_any_context_irq() to register IRQ handler
authorFederico Vaga <federico.vaga@cern.ch>
Thu, 22 Aug 2019 13:21:32 +0000 (15:21 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Thu, 29 Aug 2019 20:12:19 +0000 (22:12 +0200)
The i2c-ocores device is an HDL component that get instantiated in FPGA.
The software stack used to drive an FPGA can be very different, and the
i2c-ocore ip-core must work in different context. With respect to this
patch the IRQ controller behind this device, and its driver, can have
different implementations (nested threads). For this reason, it is safer
to use `request_any_context_irq()` to avoid errors at probe time.

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-ocores.c

index 4117f1a..ca8b3ec 100644 (file)
@@ -703,8 +703,9 @@ static int ocores_i2c_probe(struct platform_device *pdev)
        }
 
        if (ocores_algorithm.master_xfer != ocores_xfer_polling) {
-               ret = devm_request_irq(&pdev->dev, irq, ocores_isr, 0,
-                                      pdev->name, i2c);
+               ret = devm_request_any_context_irq(&pdev->dev, irq,
+                                                  ocores_isr, 0,
+                                                  pdev->name, i2c);
                if (ret) {
                        dev_err(&pdev->dev, "Cannot claim IRQ\n");
                        goto err_clk;