scsi: cxgb4i: Remove an unnecessary NULL check for 'cconn' pointer
authorVarun Prakash <varun@chelsio.com>
Tue, 14 Jul 2020 15:49:11 +0000 (21:19 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 15 Jul 2020 20:06:41 +0000 (16:06 -0400)
'cconn' will never be NULL in cxgbi_conn_alloc_pdu() so remove NULL check.

Link: https://lore.kernel.org/r/1594741751-3323-1-git-send-email-varun@chelsio.com
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Varun Prakash <varun@chelsio.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/cxgbi/libcxgbi.c

index 4c55584..932dbd4 100644 (file)
@@ -1889,7 +1889,7 @@ int cxgbi_conn_alloc_pdu(struct iscsi_task *task, u8 op)
        struct iscsi_tcp_conn *tcp_conn = conn->dd_data;
        struct cxgbi_conn *cconn = tcp_conn->dd_data;
        struct cxgbi_device *cdev = cconn->chba->cdev;
-       struct cxgbi_sock *csk = (cconn && cconn->cep) ? cconn->cep->csk : NULL;
+       struct cxgbi_sock *csk = cconn->cep ? cconn->cep->csk : NULL;
        struct iscsi_tcp_task *tcp_task = task->dd_data;
        struct cxgbi_task_data *tdata = iscsi_task_cxgbi_data(task);
        struct scsi_cmnd *sc = task->sc;