staging: rtl8188eu: remove all DBG_88E calls from core/rtw_xmit.c

Remove all DBG_88E calls from core/rtw_xmit.c as this macro is
unnecessary, and many of these calls are dubious in terms of necessity.
Removing all calls will ultimately allow the removal of the macro
itself.

Also remove static rtw_sctx_chk_warning_status function, as it no longer
has any callers.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210615001507.1171-3-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index 718dd20..07c2171 100644 (file)
--- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
+++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
@@ -364,8 +364,6 @@ u8 qos_acm(u8 acm_mask, u8 priority)
                        change_priority = 5;
                break;
        default:
-               DBG_88E("%s(): invalid pattrib->priority: %d!!!\n",
-                       __func__, priority);
                break;
        }
 
@@ -481,7 +479,6 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p
 
        if (psta) {
                pattrib->mac_id = psta->mac_id;
-               /* DBG_88E("%s ==> mac_id(%d)\n", __func__, pattrib->mac_id); */
                pattrib->psta = psta;
        } else {
                /*  if we cannot get psta => drop the pkt */
@@ -926,10 +923,8 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct
        if (!psta)
                return _FAIL;
 
-       if (!pxmitframe->buf_addr) {
-               DBG_88E("==> %s buf_addr == NULL\n", __func__);
+       if (!pxmitframe->buf_addr)
                return _FAIL;
-       }
 
        pbuf_start = pxmitframe->buf_addr;
 
@@ -939,7 +934,6 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct
 
        if (rtw_make_wlanhdr(padapter, mem_start, pattrib) == _FAIL) {
                RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("%s: rtw_make_wlanhdr fail; drop pkt\n", __func__));
-               DBG_88E("%s: rtw_make_wlanhdr fail; drop pkt\n", __func__);
                res = _FAIL;
                goto exit;
        }
@@ -1040,7 +1034,6 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct
 
        if (xmitframe_addmic(padapter, pxmitframe) == _FAIL) {
                RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("xmitframe_addmic(padapter, pxmitframe) == _FAIL\n"));
-               DBG_88E("xmitframe_addmic(padapter, pxmitframe) == _FAIL\n");
                res = _FAIL;
                goto exit;
        }
@@ -1153,10 +1146,8 @@ struct xmit_buf *rtw_alloc_xmitbuf_ext(struct xmit_priv *pxmitpriv)
                list_del_init(&pxmitbuf->list);
                pxmitpriv->free_xmit_extbuf_cnt--;
                pxmitbuf->priv_data = NULL;
-               if (pxmitbuf->sctx) {
-                       DBG_88E("%s pxmitbuf->sctx is not NULL\n", __func__);
+               if (pxmitbuf->sctx)
                        rtw_sctx_done_err(&pxmitbuf->sctx, RTW_SCTX_DONE_BUF_ALLOC);
-               }
        }
        spin_unlock_irqrestore(&pfree_queue->lock, irql);
 
@@ -1197,7 +1188,6 @@ struct xmit_buf *rtw_alloc_xmitbuf(struct xmit_priv *pxmitpriv)
                pxmitpriv->free_xmitbuf_cnt--;
                pxmitbuf->priv_data = NULL;
                if (pxmitbuf->sctx) {
-                       DBG_88E("%s pxmitbuf->sctx is not NULL\n", __func__);
                        rtw_sctx_done_err(&pxmitbuf->sctx, RTW_SCTX_DONE_BUF_ALLOC);
                }
        }
@@ -1214,10 +1204,8 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
        if (!pxmitbuf)
                return _FAIL;
 
-       if (pxmitbuf->sctx) {
-               DBG_88E("%s pxmitbuf->sctx is not NULL\n", __func__);
+       if (pxmitbuf->sctx)
                rtw_sctx_done_err(&pxmitbuf->sctx, RTW_SCTX_DONE_BUF_FREE);
-       }
 
        if (pxmitbuf->ext_tag) {
                rtw_free_xmitbuf_ext(pxmitpriv, pxmitbuf);
@@ -1482,7 +1470,6 @@ s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe)
 
        if (!psta) {
                res = _FAIL;
-               DBG_88E("%s: psta == NULL\n", __func__);
                RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("%s: psta == NULL\n", __func__));
                goto exit;
        }
@@ -1591,7 +1578,6 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_buff **ppkt)
        pxmitframe = rtw_alloc_xmitframe(pxmitpriv);
        if (!pxmitframe) {
                RT_TRACE(_module_xmit_osdep_c_, _drv_err_, ("%s: no more pxmitframe\n", __func__));
-               DBG_88E("DBG_TX_DROP_FRAME %s no more pxmitframe\n", __func__);
                return -1;
        }
 
@@ -1992,7 +1978,6 @@ int rtw_sctx_wait(struct submit_ctx *sctx)
        if (!wait_for_completion_timeout(&sctx->done, expire)) {
                /* timeout, do something?? */
                status = RTW_SCTX_DONE_TIMEOUT;
-               DBG_88E("%s timeout\n", __func__);
        } else {
                status = sctx->status;
        }
@@ -2003,26 +1988,9 @@ int rtw_sctx_wait(struct submit_ctx *sctx)
        return ret;
 }
 
-static bool rtw_sctx_chk_warning_status(int status)
-{
-       switch (status) {
-       case RTW_SCTX_DONE_UNKNOWN:
-       case RTW_SCTX_DONE_BUF_ALLOC:
-       case RTW_SCTX_DONE_BUF_FREE:
-
-       case RTW_SCTX_DONE_DRV_STOP:
-       case RTW_SCTX_DONE_DEV_REMOVE:
-               return true;
-       default:
-               return false;
-       }
-}
-
 void rtw_sctx_done_err(struct submit_ctx **sctx, int status)
 {
        if (*sctx) {
-               if (rtw_sctx_chk_warning_status(status))
-                       DBG_88E("%s status:%d\n", __func__, status);
                (*sctx)->status = status;
                complete(&((*sctx)->done));
                *sctx = NULL;
@@ -2046,6 +2014,4 @@ void rtw_ack_tx_done(struct xmit_priv *pxmitpriv, int status)
 
        if (pxmitpriv->ack_tx)
                rtw_sctx_done_err(&pack_tx_ops, status);
-       else
-               DBG_88E("%s ack_tx not set\n", __func__);
 }