applemedia: error out if the uri property is not set
authorMatthew Waters <matthew@centricular.com>
Thu, 17 Nov 2016 03:21:23 +0000 (14:21 +1100)
committerMatthew Waters <matthew@centricular.com>
Thu, 17 Nov 2016 06:30:54 +0000 (17:30 +1100)
Fixes:

Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** +[NSString stringWithUTF8String:]: NULL cString

in the state change test.

sys/applemedia/avfassetsrc.m

index 8568281..7cb9855 100644 (file)
@@ -246,6 +246,12 @@ gst_avf_asset_src_change_state (GstElement * element, GstStateChange transition)
   switch (transition) {
     case GST_STATE_CHANGE_NULL_TO_READY: {
       self->state = GST_AVF_ASSET_SRC_STATE_STOPPED;
+      if (!self->uri) {
+        GST_ELEMENT_ERROR (element, RESOURCE, NOT_FOUND,
+            ("\"uri\" property not set"), (NULL));
+        gst_avf_asset_src_stop_all (self);
+        return GST_STATE_CHANGE_FAILURE;
+      }
       self->reader = [[GstAVFAssetReader alloc] initWithURI:self->uri:&error];
       if (error) {
         GST_ELEMENT_ERROR (element, RESOURCE, FAILED, ("AVFAssetReader error"),