smb3: fix large reads on encrypted connections
authorPaul Aurich <paul@darkrain42.org>
Mon, 31 Dec 2018 22:13:34 +0000 (14:13 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jan 2019 16:38:48 +0000 (17:38 +0100)
commit 6d2f84eee098540ae857998fe32f29b9e2cd9613 upstream.

When passing a large read to receive_encrypted_read(), ensure that the
demultiplex_thread knows that a MID was processed.  Without this, those
operations never complete.

This is a similar issue/fix to lease break handling:
commit 7af929d6d05ba5564139718e30d5bc96bdbc716a
("smb3: fix lease break problem introduced by compounding")

CC: Stable <stable@vger.kernel.org> # 4.19+
Fixes: b24df3e30cbf ("cifs: update receive_encrypted_standard to handle compounded responses")
Signed-off-by: Paul Aurich <paul@darkrain42.org>
Tested-by: Yves-Alexis Perez <corsac@corsac.net>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/smb2ops.c

index 812da3e..f44bb4a 100644 (file)
@@ -3184,8 +3184,10 @@ smb3_receive_transform(struct TCP_Server_Info *server,
        }
 
        /* TODO: add support for compounds containing READ. */
-       if (pdu_length > CIFSMaxBufSize + MAX_HEADER_SIZE(server))
+       if (pdu_length > CIFSMaxBufSize + MAX_HEADER_SIZE(server)) {
+               *num_mids = 1;
                return receive_encrypted_read(server, &mids[0]);
+       }
 
        return receive_encrypted_standard(server, mids, bufs, num_mids);
 }