cpufreq: Prefer to print cpuid in MIN/MAX QoS register error message
authorLiao Chang <liaochang1@huawei.com>
Tue, 15 Aug 2023 01:40:02 +0000 (09:40 +0800)
committerViresh Kumar <viresh.kumar@linaro.org>
Thu, 17 Aug 2023 08:42:11 +0000 (14:12 +0530)
When a cpufreq_policy is allocated, the cpus, related_cpus and real_cpus
of policy are still unset. Therefore, it is preferable to print the
passed 'cpu' parameter instead of a empty 'cpus' cpumask in error
message when registering MIN/MAX QoS notifier fails.

Signed-off-by: Liao Chang <liaochang1@huawei.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/cpufreq.c

index 50bbc969ffe5309f429fbdc82f8e30cb68125d8e..a757f90aa9d62848f49ce9f60b8b3c1125f888dd 100644 (file)
@@ -1234,16 +1234,16 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu)
        ret = freq_qos_add_notifier(&policy->constraints, FREQ_QOS_MIN,
                                    &policy->nb_min);
        if (ret) {
-               dev_err(dev, "Failed to register MIN QoS notifier: %d (%*pbl)\n",
-                       ret, cpumask_pr_args(policy->cpus));
+               dev_err(dev, "Failed to register MIN QoS notifier: %d (CPU%u)\n",
+                       ret, cpu);
                goto err_kobj_remove;
        }
 
        ret = freq_qos_add_notifier(&policy->constraints, FREQ_QOS_MAX,
                                    &policy->nb_max);
        if (ret) {
-               dev_err(dev, "Failed to register MAX QoS notifier: %d (%*pbl)\n",
-                       ret, cpumask_pr_args(policy->cpus));
+               dev_err(dev, "Failed to register MAX QoS notifier: %d (CPU%u)\n",
+                       ret, cpu);
                goto err_min_qos_notifier;
        }