drm/radeon: Fix multiple line dereference in 'atom_iio_execute'
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Wed, 9 Aug 2023 09:42:31 +0000 (15:12 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 15 Aug 2023 21:43:48 +0000 (17:43 -0400)
Fixes the following:

WARNING: Avoid multiple line dereference - prefer 'ctx->io_attr'
+                           ((ctx->
+                             io_attr >> CU8(base + 2)) & (0xFFFFFFFF >> (32 -

Cc: Guchun Chen <guchun.chen@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/atom.c

index 93acb0e..ceb6d77 100644 (file)
@@ -163,13 +163,9 @@ static uint32_t atom_iio_execute(struct atom_context *ctx, int base,
                            ~((0xFFFFFFFF >> (32 - CU8(base + 1))) <<
                              CU8(base + 3));
                        temp |=
-                           ((ctx->
-                             io_attr >> CU8(base + 2)) & (0xFFFFFFFF >> (32 -
-                                                                         CU8
-                                                                         (base
-                                                                          +
-                                                                          1))))
-                           << CU8(base + 3);
+                           ((ctx->io_attr >> CU8(base + 2)) &
+                            (0xFFFFFFFF >> (32 - CU8(base + 1)))) <<
+                            CU8(base + 3);
                        base += 4;
                        break;
                case ATOM_IIO_END: