nvme-core: remove unnecessary function parameter
authorChaitanya Kulkarni <kch@nvidia.com>
Sat, 22 Jan 2022 05:05:39 +0000 (21:05 -0800)
committerChristoph Hellwig <hch@lst.de>
Mon, 28 Feb 2022 11:45:04 +0000 (13:45 +0200)
In function nvme_execute_rq() we don't use gendisk parameter at all.
Remove the unsed parameter and adjust the calls.

Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c

index a1d793e799825f1153695cba17f5b1e0a2c87dd2..dd18861f77c059e9e55654aa848b10b5c5ee1704 100644 (file)
@@ -1049,8 +1049,7 @@ EXPORT_SYMBOL_GPL(nvme_setup_cmd);
  * >0: nvme controller's cqe status response
  * <0: kernel error in lieu of controller response
  */
-static int nvme_execute_rq(struct gendisk *disk, struct request *rq,
-               bool at_head)
+static int nvme_execute_rq(struct request *rq, bool at_head)
 {
        blk_status_t status;
 
@@ -1090,7 +1089,7 @@ int __nvme_submit_sync_cmd(struct request_queue *q, struct nvme_command *cmd,
                        goto out;
        }
 
-       ret = nvme_execute_rq(NULL, req, at_head);
+       ret = nvme_execute_rq(req, at_head);
        if (result && ret >= 0)
                *result = nvme_req(req)->result;
  out:
@@ -1206,12 +1205,11 @@ int nvme_execute_passthru_rq(struct request *rq)
        struct nvme_command *cmd = nvme_req(rq)->cmd;
        struct nvme_ctrl *ctrl = nvme_req(rq)->ctrl;
        struct nvme_ns *ns = rq->q->queuedata;
-       struct gendisk *disk = ns ? ns->disk : NULL;
        u32 effects;
        int  ret;
 
        effects = nvme_passthru_start(ctrl, ns, cmd->common.opcode);
-       ret = nvme_execute_rq(disk, rq, false);
+       ret = nvme_execute_rq(rq, false);
        if (effects) /* nothing to be done for zero cmd effects */
                nvme_passthru_end(ctrl, effects, cmd, ret);