media: i2c: max9286: Fix some redundant of_node_put() calls
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 25 Aug 2023 22:13:40 +0000 (00:13 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:52:14 +0000 (11:52 +0100)
[ Upstream commit 0822315e46b400f611cba1193456ee6a5dc3e41d ]

This is odd to have a of_node_put() just after a for_each_child_of_node()
or a for_each_endpoint_of_node() loop. It should already be called
during the last iteration.

Remove these calls.

Fixes: 66d8c9d2422d ("media: i2c: Add MAX9286 driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/i2c/max9286.c

index 892cd97b7cab787c417102597b4bce9b2c55bfc1..e8c28902d97e9c3d090b68361e4a0fe9d49fed82 100644 (file)
@@ -1234,7 +1234,6 @@ static int max9286_parse_dt(struct max9286_priv *priv)
 
                i2c_mux_mask |= BIT(id);
        }
-       of_node_put(node);
        of_node_put(i2c_mux);
 
        /* Parse the endpoints */
@@ -1298,7 +1297,6 @@ static int max9286_parse_dt(struct max9286_priv *priv)
                priv->source_mask |= BIT(ep.port);
                priv->nsources++;
        }
-       of_node_put(node);
 
        /*
         * Parse the initial value of the reverse channel amplitude from