block/rnbd-srv: no need to check sess_dev
authorGuoqing Jiang <guoqing.jiang@linux.dev>
Wed, 24 May 2023 07:00:22 +0000 (15:00 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 12 Jun 2023 01:48:42 +0000 (19:48 -0600)
Check ret is enough since if sess_dev is NULL which also
implies ret should be 0.

Acked-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
Link: https://lore.kernel.org/r/20230524070026.2932-5-guoqing.jiang@linux.dev
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/rnbd/rnbd-srv.c

index 1eb3aec..f610dfc 100644 (file)
@@ -96,7 +96,7 @@ rnbd_get_sess_dev(int dev_id, struct rnbd_srv_session *srv_sess)
                ret = kref_get_unless_zero(&sess_dev->kref);
        rcu_read_unlock();
 
-       if (!sess_dev || !ret)
+       if (!ret)
                return ERR_PTR(-ENXIO);
 
        return sess_dev;