clk: renesas: mstp: Delete unnecessary kfree() in cpg_mstp_clocks_init()
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 27 Aug 2019 13:22:12 +0000 (15:22 +0200)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 1 Oct 2019 07:50:28 +0000 (09:50 +0200)
A NULL pointer would be passed to a call of the function kfree()
directly after a call of the function kzalloc() failed at one place.
Remove this superfluous function call.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://lore.kernel.org/r/e66b822b-026b-29cc-e461-6334aafd1d30@web.de
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/clk/renesas/clk-mstp.c

index e326e6d..003e9ce 100644 (file)
@@ -189,10 +189,8 @@ static void __init cpg_mstp_clocks_init(struct device_node *np)
        unsigned int i;
 
        group = kzalloc(struct_size(group, clks, MSTP_MAX_CLOCKS), GFP_KERNEL);
-       if (group == NULL) {
-               kfree(group);
+       if (!group)
                return;
-       }
 
        clks = group->clks;
        spin_lock_init(&group->lock);