fix svace issue 55/213355/1 accepted/tizen/unified/20190916.111631 submit/tizen/20190905.095244
authorwansu.yoo <wansu.yoo@samsung.com>
Wed, 4 Sep 2019 10:34:51 +0000 (19:34 +0900)
committerwansu.yoo <wansu.yoo@samsung.com>
Wed, 4 Sep 2019 10:34:51 +0000 (19:34 +0900)
WGID : 386428, Checker : PROC_USE.VULNERABLE
WGID : 386429, Checker : PROC_USE.VULNERABLE

Change-Id: If1f4f886e6422b3f9cf075665de6b989580f1547
Signed-off-by: wansu.yoo <wansu.yoo@samsung.com>
libedge-orchestration/sample/main_chrome.c

index 4b6e0d2..420b15a 100644 (file)
@@ -30,6 +30,7 @@
 int get_ip_addr(char ipstr[40]) {
     int fd;
     struct ifreq ifr;
+    char *addr;
 
     fd = socket(AF_INET, SOCK_DGRAM, 0);
     ifr.ifr_addr.sa_family = AF_INET;
@@ -39,7 +40,8 @@ int get_ip_addr(char ipstr[40]) {
     ioctl(fd, SIOCGIFADDR, &ifr);
     close(fd);
 
-    strcpy(ipstr, inet_ntoa(((struct sockaddr_in *)&ifr.ifr_addr)->sin_addr));
+    addr = inet_ntoa(((struct sockaddr_in *)&ifr.ifr_addr)->sin_addr);
+    strncpy(ipstr, addr, strlen(addr));
     return 0;
 }
 
@@ -58,7 +60,7 @@ int main() {
     orchestration_service_info_s service_info;
     service_info.count = 1;
     service_info.services[0].exec_type = "native";
-    service_info.services[0].exec_parameter = strcat(command, ipstr);
+    service_info.services[0].exec_parameter = strncat(command, ipstr, strlen(ipstr));
     printf("service_info.exec_parameter: %s\n", service_info.services[0].exec_parameter);
     orchestration_request_service("org.tizen.chromium-efl", service_info, status_cb, NULL);
     return 0;