virt: acrn: obtain pa from VMA with PFNMAP flag
authorYonghua Huang <yonghua.huang@intel.com>
Mon, 28 Feb 2022 02:22:12 +0000 (05:22 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:50 +0000 (14:23 +0200)
[ Upstream commit 8a6e85f75a83d16a71077e41f2720c691f432002 ]

 acrn_vm_ram_map can't pin the user pages with VM_PFNMAP flag
 by calling get_user_pages_fast(), the PA(physical pages)
 may be mapped by kernel driver and set PFNMAP flag.

 This patch fixes logic to setup EPT mapping for PFN mapped RAM region
 by checking the memory attribute before adding EPT mapping for them.

Fixes: 88f537d5e8dd ("virt: acrn: Introduce EPT mapping management")
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Signed-off-by: Fei Li <fei1.li@intel.com>
Link: https://lore.kernel.org/r/20220228022212.419406-1-yonghua.huang@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/virt/acrn/mm.c

index c4f2e15..3b1b1e7 100644 (file)
@@ -162,10 +162,34 @@ int acrn_vm_ram_map(struct acrn_vm *vm, struct acrn_vm_memmap *memmap)
        void *remap_vaddr;
        int ret, pinned;
        u64 user_vm_pa;
+       unsigned long pfn;
+       struct vm_area_struct *vma;
 
        if (!vm || !memmap)
                return -EINVAL;
 
+       mmap_read_lock(current->mm);
+       vma = vma_lookup(current->mm, memmap->vma_base);
+       if (vma && ((vma->vm_flags & VM_PFNMAP) != 0)) {
+               if ((memmap->vma_base + memmap->len) > vma->vm_end) {
+                       mmap_read_unlock(current->mm);
+                       return -EINVAL;
+               }
+
+               ret = follow_pfn(vma, memmap->vma_base, &pfn);
+               mmap_read_unlock(current->mm);
+               if (ret < 0) {
+                       dev_dbg(acrn_dev.this_device,
+                               "Failed to lookup PFN at VMA:%pK.\n", (void *)memmap->vma_base);
+                       return ret;
+               }
+
+               return acrn_mm_region_add(vm, memmap->user_vm_pa,
+                        PFN_PHYS(pfn), memmap->len,
+                        ACRN_MEM_TYPE_WB, memmap->attr);
+       }
+       mmap_read_unlock(current->mm);
+
        /* Get the page number of the map region */
        nr_pages = memmap->len >> PAGE_SHIFT;
        pages = vzalloc(nr_pages * sizeof(struct page *));