pinctrl: mcp23s08: Fix mcp23x17 precious range
authorThomas Preston <thomas.preston@codethink.co.uk>
Fri, 28 Aug 2020 21:32:26 +0000 (22:32 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 12 Sep 2020 09:31:19 +0000 (11:31 +0200)
On page 23 of the datasheet [0] it says "The register remains unchanged
until the interrupt is cleared via a read of INTCAP or GPIO." Include
INTCAPA and INTCAPB registers in precious range, so that they aren't
accidentally cleared when we read via debugfs.

[0] https://ww1.microchip.com/downloads/en/DeviceDoc/20001952C.pdf

Fixes: 8f38910ba4f6 ("pinctrl: mcp23s08: switch to regmap caching")
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200828213226.1734264-3-thomas.preston@codethink.co.uk
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-mcp23s08.c

index 3f5fed2..ce2d801 100644 (file)
@@ -109,7 +109,7 @@ static const struct regmap_access_table mcp23x17_volatile_table = {
 };
 
 static const struct regmap_range mcp23x17_precious_range = {
-       .range_min = MCP_GPIO << 1,
+       .range_min = MCP_INTCAP << 1,
        .range_max = MCP_GPIO << 1,
 };