KVM: x86: Setting rflags.rf during rep-string emulation
authorNadav Amit <namit@cs.technion.ac.il>
Thu, 24 Jul 2014 11:51:23 +0000 (14:51 +0300)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 24 Jul 2014 12:03:54 +0000 (14:03 +0200)
This patch updates RF for rep-string emulation.  The flag is set upon the first
iteration, and cleared after the last (if emulated). It is intended to make
sure that if a trap (in future data/io #DB emulation) or interrupt is delivered
to the guest during the rep-string instruction, RF will be set correctly. RF
affects whether instruction breakpoint in the guest is masked.

Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/emulate.c

index 8d41556..57743ed 100644 (file)
@@ -4683,7 +4683,10 @@ special_insn:
                        goto done;
        }
 
-       ctxt->eflags &= ~EFLG_RF;
+       if (ctxt->rep_prefix && (ctxt->d & String))
+               ctxt->eflags |= EFLG_RF;
+       else
+               ctxt->eflags &= ~EFLG_RF;
 
        if (ctxt->execute) {
                if (ctxt->d & Fastop) {
@@ -4824,6 +4827,7 @@ writeback:
                        }
                        goto done; /* skip rip writeback */
                }
+               ctxt->eflags &= ~EFLG_RF;
        }
 
        ctxt->eip = ctxt->_eip;