proc: remove mark_inode_dirty() in .setattr()

procfs' .setattr() has updated i_uid, i_gid and i_mode into proc dirent,
we don't need to call mark_inode_dirty() for delayed update, remove it.

Link: https://lkml.kernel.org/r/20230131150840.34726-1-chao@kernel.org
Signed-off-by: Chao Yu <chao@kernel.org>
Reviewed-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 5e0e0cc..e34e060 100644 (file)
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -699,7 +699,6 @@ int proc_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
                return error;
 
        setattr_copy(&nop_mnt_idmap, inode, attr);
-       mark_inode_dirty(inode);
        return 0;
 }
 

diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 8379593..42ae38f 100644 (file)
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -127,7 +127,6 @@ static int proc_notify_change(struct mnt_idmap *idmap,
                return error;
 
        setattr_copy(&nop_mnt_idmap, inode, iattr);
-       mark_inode_dirty(inode);
 
        proc_set_user(de, inode->i_uid, inode->i_gid);
        de->mode = inode->i_mode;

diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 5851eb5..875771b 100644 (file)
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c
@@ -841,7 +841,6 @@ static int proc_sys_setattr(struct mnt_idmap *idmap,
                return error;
 
        setattr_copy(&nop_mnt_idmap, inode, attr);
-       mark_inode_dirty(inode);
        return 0;
 }