RDMA/hns: Remove unnecessary QP type checks
authorJunxian Huang <huangjunxian6@hisilicon.com>
Tue, 23 May 2023 12:16:39 +0000 (20:16 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 1 Jun 2023 22:58:47 +0000 (19:58 -0300)
It is not necessary to check the type of the queue on IO path because
unsupported QP type cannot be created.

Link: https://lore.kernel.org/r/20230523121641.3132102-2-huangjunxian6@hisilicon.com
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index 84f1167..eba5fdc 100644 (file)
@@ -373,17 +373,10 @@ static int check_send_valid(struct hns_roce_dev *hr_dev,
                            struct hns_roce_qp *hr_qp)
 {
        struct ib_device *ibdev = &hr_dev->ib_dev;
-       struct ib_qp *ibqp = &hr_qp->ibqp;
 
-       if (unlikely(ibqp->qp_type != IB_QPT_RC &&
-                    ibqp->qp_type != IB_QPT_GSI &&
-                    ibqp->qp_type != IB_QPT_UD)) {
-               ibdev_err(ibdev, "not supported QP(0x%x)type!\n",
-                         ibqp->qp_type);
-               return -EOPNOTSUPP;
-       } else if (unlikely(hr_qp->state == IB_QPS_RESET ||
-                  hr_qp->state == IB_QPS_INIT ||
-                  hr_qp->state == IB_QPS_RTR)) {
+       if (unlikely(hr_qp->state == IB_QPS_RESET ||
+                    hr_qp->state == IB_QPS_INIT ||
+                    hr_qp->state == IB_QPS_RTR)) {
                ibdev_err(ibdev, "failed to post WQE, QP state %u!\n",
                          hr_qp->state);
                return -EINVAL;
@@ -771,17 +764,6 @@ out:
 static int check_recv_valid(struct hns_roce_dev *hr_dev,
                            struct hns_roce_qp *hr_qp)
 {
-       struct ib_device *ibdev = &hr_dev->ib_dev;
-       struct ib_qp *ibqp = &hr_qp->ibqp;
-
-       if (unlikely(ibqp->qp_type != IB_QPT_RC &&
-                    ibqp->qp_type != IB_QPT_GSI &&
-                    ibqp->qp_type != IB_QPT_UD)) {
-               ibdev_err(ibdev, "unsupported qp type, qp_type = %d.\n",
-                         ibqp->qp_type);
-               return -EOPNOTSUPP;
-       }
-
        if (unlikely(hr_dev->state >= HNS_ROCE_DEVICE_STATE_RST_DOWN))
                return -EIO;