shell: Don’t change popups’ window types until the next configure event
authorPhilip Withnall <philip.withnall@collabora.co.uk>
Mon, 25 Nov 2013 18:01:39 +0000 (18:01 +0000)
committerKristian Høgsberg <krh@bitplanet.net>
Mon, 2 Dec 2013 19:44:50 +0000 (11:44 -0800)
This standardises their behaviour with that of the other window types,
where the type change is only committed on configure.

src/shell.c

index e9d733c..2bfc463 100644 (file)
@@ -2192,13 +2192,14 @@ set_popup(struct shell_surface *shsurf,
 {
        assert(parent != NULL);
 
-       shsurf->type = SHELL_SURFACE_POPUP;
        shsurf->popup.shseat = get_shell_seat(seat);
        shsurf->popup.serial = serial;
        shsurf->popup.x = x;
        shsurf->popup.y = y;
 
        shell_surface_set_parent(shsurf, parent);
+
+       shsurf->next_type = SHELL_SURFACE_POPUP;
 }
 
 static void