scsi: qla2xxx: Use constant when it is known
authorPavel Machek (CIP) <pavel@denx.de>
Mon, 21 Sep 2020 11:23:40 +0000 (13:23 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 8 Oct 2020 03:50:03 +0000 (23:50 -0400)
Directly return constant when it is known to make code easier to
understand.

Link: https://lore.kernel.org/r/20200921112340.GA19336@duo.ucw.cz
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_nvme.c

index 5cc1bbb..ccec660 100644 (file)
@@ -542,7 +542,7 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
        fc_port_t *fcport;
        struct srb_iocb *nvme;
        struct scsi_qla_host *vha;
-       int rval = -ENODEV;
+       int rval;
        srb_t *sp;
        struct qla_qpair *qpair = hw_queue_handle;
        struct nvme_private *priv = fd->private;
@@ -550,14 +550,14 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
 
        if (!priv) {
                /* nvme association has been torn down */
-               return rval;
+               return -ENODEV;
        }
 
        fcport = qla_rport->fcport;
 
        if (!qpair || !fcport || (qpair && !qpair->fw_started) ||
            (fcport && fcport->deleted))
-               return rval;
+               return -ENODEV;
 
        vha = fcport->vha;