bcache: make kobj_type structures constant
authorThomas Weißschuh <linux@weissschuh.net>
Thu, 15 Jun 2023 12:12:19 +0000 (20:12 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 15 Jun 2023 13:30:11 +0000 (07:30 -0600)
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definitions to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Signed-off-by: Coly Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20230615121223.22502-3-colyli@suse.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/bcache.h
drivers/md/bcache/sysfs.h

index 700dc55..5a79bb3 100644 (file)
@@ -1004,11 +1004,11 @@ extern struct workqueue_struct *bch_flush_wq;
 extern struct mutex bch_register_lock;
 extern struct list_head bch_cache_sets;
 
-extern struct kobj_type bch_cached_dev_ktype;
-extern struct kobj_type bch_flash_dev_ktype;
-extern struct kobj_type bch_cache_set_ktype;
-extern struct kobj_type bch_cache_set_internal_ktype;
-extern struct kobj_type bch_cache_ktype;
+extern const struct kobj_type bch_cached_dev_ktype;
+extern const struct kobj_type bch_flash_dev_ktype;
+extern const struct kobj_type bch_cache_set_ktype;
+extern const struct kobj_type bch_cache_set_internal_ktype;
+extern const struct kobj_type bch_cache_ktype;
 
 void bch_cached_dev_release(struct kobject *kobj);
 void bch_flash_dev_release(struct kobject *kobj);
index a2ff644..65b8bd9 100644 (file)
@@ -3,7 +3,7 @@
 #define _BCACHE_SYSFS_H_
 
 #define KTYPE(type)                                                    \
-struct kobj_type type ## _ktype = {                                    \
+const struct kobj_type type ## _ktype = {                                      \
        .release        = type ## _release,                             \
        .sysfs_ops      = &((const struct sysfs_ops) {                  \
                .show   = type ## _show,                                \