projects / platform / core / ml / nnfw.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: faed767)
Fix to proper check on non-empty string (#6659)
author박천교/On-Device Lab(SR)/Engineer/삼성전자 <ch.bahk@samsung.com>
Mon, 19 Aug 2019 01:10:57 +0000 (10:10 +0900)
committer오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 <hseok82.oh@samsung.com>
Mon, 19 Aug 2019 01:10:57 +0000 (10:10 +0900)
Previously checking whether shell variable is non-empty worked not as
expected. This commit fixes to do this function as expected.

Signed-off-by: Cheongyo Bahk <ch.bahk@samsung.com>
infra/scripts/docker_build_cross_arm_benchmark_model.sh patch | blob | history
infra/scripts/docker_build_cross_arm_neurun.sh patch | blob | history
infra/scripts/docker_build_cross_arm_neurun_release.sh patch | blob | history
infra/scripts/docker_build_cross_arm_pacl.sh patch | blob | history
infra/scripts/docker_build_cross_arm_pacl_release.sh patch | blob | history
infra/scripts/docker_build_cross_coverage.sh patch | blob | history
infra/scripts/docker_build_test_x64.sh patch | blob | history
infra/scripts/docker_build_tizen_cross.sh patch | blob | history

diff --git a/infra/scripts/docker_build_cross_arm_benchmark_model.sh b/infra/scripts/docker_build_cross_arm_benchmark_model.sh
index e2996e8..0bc20b1 100755 (executable)
--- a/infra/scripts/docker_build_cross_arm_benchmark_model.sh
+++ b/infra/scripts/docker_build_cross_arm_benchmark_model.sh
@@ -14,7 +14,7 @@ else
 fi
 
 # mount volume (or directory) for externals
-if [ -n $EXTERNAL_VOLUME ]; then
+if [ -n "$EXTERNAL_VOLUME" ]; then
   DOCKER_VOLUMES+=" -v $EXTERNAL_VOLUME:/externals"
   DOCKER_ENV_VARS+=" -e EXTERNAL_VOLUME=/externals"
 else
diff --git a/infra/scripts/docker_build_cross_arm_neurun.sh b/infra/scripts/docker_build_cross_arm_neurun.sh
index b91ddd9..c1014c5 100755 (executable)
--- a/infra/scripts/docker_build_cross_arm_neurun.sh
+++ b/infra/scripts/docker_build_cross_arm_neurun.sh
@@ -14,7 +14,7 @@ else
 fi
 
 # mount volume (or directory) for externals
-if [ -n $EXTERNAL_VOLUME ]; then
+if [ -n "$EXTERNAL_VOLUME" ]; then
   DOCKER_VOLUMES+=" -v $EXTERNAL_VOLUME:/externals"
   DOCKER_ENV_VARS+=" -e EXTERNAL_VOLUME=/externals"
 else
diff --git a/infra/scripts/docker_build_cross_arm_neurun_release.sh b/infra/scripts/docker_build_cross_arm_neurun_release.sh
index bf4ad6b..c8c3e99 100755 (executable)
--- a/infra/scripts/docker_build_cross_arm_neurun_release.sh
+++ b/infra/scripts/docker_build_cross_arm_neurun_release.sh
@@ -14,7 +14,7 @@ else
 fi
 
 # mount volume (or directory) for externals
-if [ -n $EXTERNAL_VOLUME ]; then
+if [ -n "$EXTERNAL_VOLUME" ]; then
   DOCKER_VOLUMES+=" -v $EXTERNAL_VOLUME:/externals"
   DOCKER_ENV_VARS+=" -e EXTERNAL_VOLUME=/externals"
 else
diff --git a/infra/scripts/docker_build_cross_arm_pacl.sh b/infra/scripts/docker_build_cross_arm_pacl.sh
index aab07a6..2091287 100755 (executable)
--- a/infra/scripts/docker_build_cross_arm_pacl.sh
+++ b/infra/scripts/docker_build_cross_arm_pacl.sh
@@ -14,7 +14,7 @@ else
 fi
 
 # mount volume (or directory) for externals
-if [ -n $EXTERNAL_VOLUME ]; then
+if [ -n "$EXTERNAL_VOLUME" ]; then
   DOCKER_VOLUMES+=" -v $EXTERNAL_VOLUME:/externals"
   DOCKER_ENV_VARS+=" -e EXTERNAL_VOLUME=/externals"
 else
diff --git a/infra/scripts/docker_build_cross_arm_pacl_release.sh b/infra/scripts/docker_build_cross_arm_pacl_release.sh
index b021000..fdac800 100755 (executable)
--- a/infra/scripts/docker_build_cross_arm_pacl_release.sh
+++ b/infra/scripts/docker_build_cross_arm_pacl_release.sh
@@ -14,7 +14,7 @@ else
 fi
 
 # mount volume (or directory) for externals
-if [ -n $EXTERNAL_VOLUME ]; then
+if [ -n "$EXTERNAL_VOLUME" ]; then
   DOCKER_VOLUMES+=" -v $EXTERNAL_VOLUME:/externals"
   DOCKER_ENV_VARS+=" -e EXTERNAL_VOLUME=/externals"
 else
diff --git a/infra/scripts/docker_build_cross_coverage.sh b/infra/scripts/docker_build_cross_coverage.sh
index 38240c8..661e85b 100755 (executable)
--- a/infra/scripts/docker_build_cross_coverage.sh
+++ b/infra/scripts/docker_build_cross_coverage.sh
@@ -14,7 +14,7 @@ else
 fi
 
 # mount volume (or directory) for externals
-if [ -n $EXTERNAL_VOLUME ]; then
+if [ -n "$EXTERNAL_VOLUME" ]; then
   DOCKER_VOLUMES+=" -v $EXTERNAL_VOLUME:/externals"
   DOCKER_ENV_VARS+=" -e EXTERNAL_VOLUME=/externals"
 else
diff --git a/infra/scripts/docker_build_test_x64.sh b/infra/scripts/docker_build_test_x64.sh
index d7ff798..63ba1d2 100755 (executable)
--- a/infra/scripts/docker_build_test_x64.sh
+++ b/infra/scripts/docker_build_test_x64.sh
@@ -6,7 +6,7 @@ CURRENT_PATH="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 ROOT_PATH="$CURRENT_PATH/../../"
 
 # mount volume (or directory) for externals
-if [ -n $EXTERNAL_VOLUME ]; then
+if [ -n "$EXTERNAL_VOLUME" ]; then
   DOCKER_VOLUMES+=" -v $EXTERNAL_VOLUME:/externals"
   DOCKER_ENV_VARS+=" -e EXTERNAL_VOLUME=/externals"
 else
diff --git a/infra/scripts/docker_build_tizen_cross.sh b/infra/scripts/docker_build_tizen_cross.sh
index 1ce966a..bcd0378 100755 (executable)
--- a/infra/scripts/docker_build_tizen_cross.sh
+++ b/infra/scripts/docker_build_tizen_cross.sh
@@ -14,7 +14,7 @@ else
 fi
 
 # mount volume (or directory) for externals
-if [ -n $EXTERNAL_VOLUME ]; then
+if [ -n "$EXTERNAL_VOLUME" ]; then
   DOCKER_VOLUMES+=" -v $EXTERNAL_VOLUME:/externals"
   DOCKER_ENV_VARS+=" -e EXTERNAL_VOLUME=/externals"
 else
Domain: Machine Learning / ML Framework;