install: fix NameError
authorthefourtheye <thechargingvolcano@gmail.com>
Tue, 5 May 2015 17:23:56 +0000 (22:53 +0530)
committerJeremiah Senkpiel <fishrock123@rocketmail.com>
Thu, 7 May 2015 16:42:08 +0000 (12:42 -0400)
If `len(args)` is less than two, then
`install_path = dst_dir + node_prefix + '/'` would throw a `NameError`,
because `dst_dir` will not be defined yet. So we are assigning `''` as
the default value.

PR-URL: https://github.com/iojs/io.js/pull/1628
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
tools/install.py

index a14e894..8d76a14 100755 (executable)
@@ -198,8 +198,8 @@ def run(args):
   # argv[2] is a custom install prefix for packagers (think DESTDIR)
   # argv[3] is a custom install prefix (think PREFIX)
   # Difference is that dst_dir won't be included in shebang lines etc.
-  if len(args) > 2:
-    dst_dir = args[2]
+  dst_dir = args[2] if len(args) > 2 else ''
+
   if len(args) > 3:
     node_prefix = args[3]