Fix failures
authorWalter Erquinigo <wallace@fb.com>
Wed, 15 Jun 2022 20:43:33 +0000 (13:43 -0700)
committerWalter Erquinigo <wallace@fb.com>
Wed, 15 Jun 2022 20:54:04 +0000 (13:54 -0700)
https://lab.llvm.org/buildbot/#/builders/17/builds/23269 breaks because
we are doing some asm calls that only work on x86

https://lab.llvm.org/buildbot/#/builders/68/builds/34092/steps/6/logs/stdio
breaks because some comparators where being done incorrectly.

lldb/unittests/Process/Linux/PerfTests.cpp
lldb/unittests/Utility/TraceGDBRemotePacketsTest.cpp

index c12aa09..6332cd9 100644 (file)
@@ -6,6 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
+#ifdef __x86_64__
+
 #include "Perf.h"
 
 #include "llvm/Support/Error.h"
@@ -83,3 +85,5 @@ TEST(Perf, TscConversion) {
   ASSERT_LT(converted_tsc_diff.count(),
             (SLEEP_NANOS + acceptable_overhead).count());
 }
+
+#endif // __x86_64__
index b3f8538..47f5518 100644 (file)
@@ -94,7 +94,6 @@ TEST(TraceGDBRemotePacketsTest, IntelPTGetStateResponseEmpty) {
   // portions of the JSON representation are unchanged.
   ASSERT_EQ(toJSON(response), toJSON(*deserialized_response));
   // Ensure that the tsc_conversion's are nullptr.
-  ASSERT_EQ(response.tsc_perf_zero_conversion, None);
-  ASSERT_EQ(response.tsc_perf_zero_conversion,
-            deserialized_response->tsc_perf_zero_conversion);
+  ASSERT_FALSE((bool)response.tsc_perf_zero_conversion);
+  ASSERT_FALSE((bool)deserialized_response->tsc_perf_zero_conversion);
 }