phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 5 Mar 2021 03:49:31 +0000 (03:49 +0000)
committerVinod Koul <vkoul@kernel.org>
Tue, 30 Mar 2021 18:05:17 +0000 (23:35 +0530)
Fix the return value check which testing the wrong variable
in mt7621_pci_phy_probe().

Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Link: https://lore.kernel.org/r/20210305034931.3237558-1-weiyongjun1@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/ralink/phy-mt7621-pci.c

index 84ee2b5..753cb5b 100644 (file)
@@ -319,9 +319,9 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)
                return PTR_ERR(phy->regmap);
 
        phy->phy = devm_phy_create(dev, dev->of_node, &mt7621_pci_phy_ops);
-       if (IS_ERR(phy)) {
+       if (IS_ERR(phy->phy)) {
                dev_err(dev, "failed to create phy\n");
-               return PTR_ERR(phy);
+               return PTR_ERR(phy->phy);
        }
 
        phy_set_drvdata(phy->phy, phy);