Caps with empty props (which is not NULL - gst_props_new_empty()) can result in an...

Original commit message from CVS:
Caps with empty props (which is not NULL - gst_props_new_empty()) can result in an invalid string, so we need to check for empty props (as opposed to NULL props) too.

diff --git a/gst/gstcaps.c b/gst/gstcaps.c
index 7d7b4560031df94b960fc303a81bcf1d9550d7c0..69ea7a5f0f53470f803a9ff5150829aa91c4f7bb 100644 (file)
--- a/gst/gstcaps.c
+++ b/gst/gstcaps.c
@@ -86,10 +86,13 @@ gst_caps_to_string (GstCaps *caps)
       g_value_set_boxed  (&value, caps->properties);
       props = g_strdup_value_contents (&value);
 
-      g_value_unset (&value);
-      g_string_append (result, ", ");
-      g_string_append (result, props);
-      g_free (props);
+      /* this happens with empty (but existing) caps->properties */
+      if (props[0] != '\0') {
+        g_value_unset (&value);
+        g_string_append (result, ", ");
+        g_string_append (result, props);
+        g_free (props);
+      }
     }
 
     caps = caps->next;