MergeFunc: preserve COMDAT information when creating a thunk

We would previously drop the COMDAT on the thunk we generated when replacing a
function body with the forwarding thunk. This would result in a function that
may have been multiply emitted and multiply merged to be emitted with the same
name without the COMDAT. This is a hard error with PE/COFF where the COMDAT is
used for the deduplication of Value Witness functions for Swift.

llvm-svn: 358728

diff --git a/llvm/lib/Transforms/IPO/MergeFunctions.cpp b/llvm/lib/Transforms/IPO/MergeFunctions.cpp
index 1ca4ebe..d0c1613 100644 (file)
--- a/llvm/lib/Transforms/IPO/MergeFunctions.cpp
+++ b/llvm/lib/Transforms/IPO/MergeFunctions.cpp
@@ -703,6 +703,7 @@ void MergeFunctions::writeThunk(Function *F, Function *G) {
   } else {
     NewG = Function::Create(G->getFunctionType(), G->getLinkage(),
                             G->getAddressSpace(), "", G->getParent());
+    NewG->setComdat(G->getComdat());
     BB = BasicBlock::Create(F->getContext(), "", NewG);
   }
 

diff --git a/llvm/test/Transforms/MergeFunc/comdat.ll b/llvm/test/Transforms/MergeFunc/comdat.ll
new file mode 100644 (file)
index 0000000..ce28959
--- /dev/null
+++ b/llvm/test/Transforms/MergeFunc/comdat.ll
@@ -0,0 +1,24 @@
+; RUN: opt -S -mergefunc %s | FileCheck %s
+
+@symbols = linkonce_odr global <{ i8*, i8* }> <{ i8* bitcast (i32 (i32, i32)* @f to i8*), i8* bitcast (i32 (i32, i32)* @g to i8*) }>
+
+$f = comdat any
+$g = comdat any
+
+define linkonce_odr hidden i32 @f(i32 %x, i32 %y) comdat {
+  %sum = add i32 %x, %y
+  %sum2 = add i32 %x, %sum
+  %sum3 = add i32 %x, %sum
+  ret i32 %sum3
+}
+
+define linkonce_odr hidden i32 @g(i32 %x, i32 %y) comdat {
+  %sum = add i32 %x, %y
+  %sum2 = add i32 %x, %sum
+  %sum3 = add i32 %x, %sum
+  ret i32 %sum3
+}
+
+; CHECK-DAG: define linkonce_odr hidden i32 @f(i32 %x, i32 %y) comdat
+; CHECK-DAG: define linkonce_odr hidden i32 @g(i32, i32) comdat
+