video: fbdev: pxafb: clear allocated memory for video modes
authorDaniel Mack <daniel@zonque.org>
Tue, 24 Jul 2018 17:11:25 +0000 (19:11 +0200)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tue, 24 Jul 2018 17:11:25 +0000 (19:11 +0200)
When parsing the video modes from DT properties, make sure to zero out
memory before using it. This is important because not all fields in the mode
struct are explicitly initialized, even though they are used later on.

Fixes: 420a488278e86 ("video: fbdev: pxafb: initial devicetree conversion")
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Daniel Mack <daniel@zonque.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/pxafb.c

index 76722a5..dfe382e 100644 (file)
@@ -2128,8 +2128,8 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp,
                return -EINVAL;
 
        ret = -ENOMEM;
-       info->modes = kmalloc_array(timings->num_timings,
-                                   sizeof(info->modes[0]), GFP_KERNEL);
+       info->modes = kcalloc(timings->num_timings, sizeof(info->modes[0]),
+                             GFP_KERNEL);
        if (!info->modes)
                goto out;
        info->num_modes = timings->num_timings;